Fix(compose): Preserve modifiers in SentryNavigable#4757
Merged
markushi merged 3 commits intogetsentry:mainfrom Sep 29, 2025
Merged
Fix(compose): Preserve modifiers in SentryNavigable#4757markushi merged 3 commits intogetsentry:mainfrom
markushi merged 3 commits intogetsentry:mainfrom
Conversation
markushi
approved these changes
Sep 29, 2025
Member
|
@VleemingM Thanks for your contribution, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Preserve modifier in SentryTraced
When
enableUserInteractionTracingis true use the provided modifier.💡 Motivation and Context
When using the enableUserInteractionTracing I noticed my Modifier was ignored. Looking at the git history for this line this looks like an unintended bug.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Note
Preserves the passed
modifierinSentryTracedby chaining.sentryTag(tag)onto it when interaction tracing is enabled, and documents the fix in the changelog.modifierinSentryTracedby usingmodifier.sentryTag(tag)instead of replacing it withModifier.sentryTag(tag).SentryTracedunder Unreleased > Fixes.Written by Cursor Bugbot for commit ea42e11. This will update automatically on new commits. Configure here.