Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
Previous results on branch: webb/use-numbered-capture-groups-for-sentry-trace-header-validation
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 51f57f8 | 419.54 ms | 470.84 ms | 51.30 ms |
| 765567d | 378.67 ms | 430.08 ms | 51.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 51f57f8 | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 765567d | 1.58 MiB | 2.10 MiB | 530.95 KiB |
lcian
approved these changes
Aug 25, 2025
markushi
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
As named capturing groups are not supported on older Android versions (<8.0 / <API level 26)
Closes #4651
💡 Motivation and Context
Only starting with API level 26 are named capture groups supported, whereas our
minSdkis set to 21.💚 How did you test it?
In Android Studio:
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps