Add E2E tests for the spring sample#4640
Merged
alexander-alderman-webb merged 6 commits intomainfrom Sep 12, 2025
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| 17a0955 | 372.53 ms | 446.70 ms | 74.17 ms |
| 85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
| ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
| ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| 17a0955 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| 85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
Previous results on branch: webb/e2e_tests_spring
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a5aaad8 | 426.89 ms | 461.90 ms | 35.00 ms |
| 2b2b647 | 390.83 ms | 431.83 ms | 41.00 ms |
| 5d1948a | 417.21 ms | 475.94 ms | 58.73 ms |
| c1fc233 | 357.19 ms | 399.57 ms | 42.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a5aaad8 | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 2b2b647 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| 5d1948a | 1.58 MiB | 2.10 MiB | 533.43 KiB |
| c1fc233 | 1.58 MiB | 2.10 MiB | 533.46 KiB |
adinauer
reviewed
Aug 29, 2025
Member
adinauer
left a comment
There was a problem hiding this comment.
Mostly LGTM, can we keep JDK 8? I'm worried that we start breaking things for customers who might still be on an old version of JDK.
sentry-samples/sentry-samples-spring/src/test/kotlin/io/sentry/systemtest/PersonSystemTest.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
Follow up on #4635, with similar changes as the
springsample is analogous to thespring-jakartasample.One notable difference is that the Spring Boot 2's BOM pulls in Kotlin and Jackson versions that are incompatible with the ones specified in our version catalogue. I therefore included Kotlin and Jackson BOMs after the Spring Boot one. As a nice side effect
spotlessGradleApplystarted working again on the sample.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps