Fix contextutils test registerreceiver overload mismatch#4608
Closed
romtsn wants to merge 1 commit intorz/perf/enhanced-executor-servicefrom
Closed
Conversation
Co-authored-by: roman.zavarnitsyn <roman.zavarnitsyn@sentry.io>
|
Cursor Agent can help with this pull request. Just |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Fix contextutils test registerreceiver overload mismatch ([#4608](https://github.com/getsentry/sentry-java/pull/4608))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Updated
ContextUtilsTestto correctly verifyContext.registerReceivercalls for API 32-.💡 Motivation and Context
The
ContextUtilsTestfor API 32- was incorrectly verifying a 4-parameter overload ofcontext.registerReceiver. In Android, the 4-parameterregisterReceivermethod internally delegates to the 5-parameter overload, passing0as the defaultflagsvalue. This fix updates the test to verify the 5-parameter overload withflags = 0, accurately reflecting the runtime behavior and aligning with how other tests verifyregisterReceivercalls.💚 How did you test it?
The updated test itself verifies the fix by asserting the correct
Context.registerReceiveroverload and parameters are called.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps