Prevent duplicate screen capture loops#4580
Closed
romtsn wants to merge 1 commit intorz/ref/capturer-main-threadfrom
Closed
Prevent duplicate screen capture loops#4580romtsn wants to merge 1 commit intorz/ref/capturer-main-threadfrom
romtsn wants to merge 1 commit intorz/ref/capturer-main-threadfrom
Conversation
Co-authored-by: roman.zavarnitsyn <roman.zavarnitsyn@sentry.io>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Prevent duplicate screen capture loops ([#4580](https://github.com/getsentry/sentry-java/pull/4580))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<pr_request_template>## 📜 Description
Ensured that only one screen capture loop is active at a time by removing existing
Capturercallbacks before scheduling new ones inonConfigurationChangedandCapturer.resume().💡 Motivation and Context
The
onConfigurationChangedandCapturer.resume()methods were causing multiple concurrent screen capture loops. This occurred because they would schedule or re-post theCapturerrunnable viamainLooperHandlerwithout first removing any existing or previously scheduled callbacks. This led to redundant capture attempts and potential performance issues. The fix prevents this by clearing previous callbacks before posting new ones.💚 How did you test it?
The fix was implemented based on code analysis to prevent redundant callback scheduling.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps</pr_request_template>
Learn more about Cursor Agents