Merged
Conversation
Added dialog configurator without context added Compose button for feedback
Contributor
|
stefanosiano
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68bd06b | 433.96 ms | 487.04 ms | 53.08 ms |
| 806ddef | 397.23 ms | 430.26 ms | 33.03 ms |
| 2fe2438 | 379.94 ms | 412.50 ms | 32.56 ms |
| ee8f48a | 477.68 ms | 519.12 ms | 41.44 ms |
| 14c91f4 | 422.98 ms | 468.08 ms | 45.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68bd06b | 1.58 MiB | 2.09 MiB | 519.27 KiB |
| 806ddef | 1.58 MiB | 2.09 MiB | 519.46 KiB |
| 2fe2438 | 1.58 MiB | 2.09 MiB | 519.46 KiB |
| ee8f48a | 1.58 MiB | 2.09 MiB | 519.46 KiB |
| 14c91f4 | 1.58 MiB | 2.09 MiB | 519.47 KiB |
markushi
requested changes
Jul 22, 2025
Member
markushi
left a comment
markushi
left a comment
There was a problem hiding this comment.
Nice one, looking good! I added a few small comments we should address before merging.
sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryUserFeedbackButton.kt
Outdated
Show resolved
Hide resolved
sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryUserFeedbackButton.kt
Show resolved
Hide resolved
sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryUserFeedbackButton.kt
Outdated
Show resolved
Hide resolved
sentry-compose/src/androidMain/res/drawable/sentry_user_feedback_compose_button_logo_24.xml
Show resolved
Hide resolved
Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
Cleaned SentryUserFeedbackDialog.Builder methods SentryFeedbackOptions is not Internal anymore
# Conflicts: # CHANGELOG.md # sentry/src/test/java/io/sentry/SentryOptionsTest.kt
markushi
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added user feedback dialog support via static API
Added dialog configurator without context
added Compose button for feedback
💡 Motivation and Context
The compose widget was the last piece to show the user feedback on Android apps
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps