Merged
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2e00745 | 440.67 ms | 489.81 ms | 49.14 ms |
| 296205e | 397.86 ms | 416.63 ms | 18.77 ms |
| 229d937 | 407.06 ms | 448.72 ms | 41.66 ms |
| d035656 | 399.04 ms | 416.73 ms | 17.69 ms |
| 771a432 | 410.52 ms | 458.84 ms | 48.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2e00745 | 1.58 MiB | 2.09 MiB | 518.68 KiB |
| 296205e | 1.58 MiB | 2.09 MiB | 518.67 KiB |
| 229d937 | 1.58 MiB | 2.09 MiB | 518.93 KiB |
| d035656 | 1.58 MiB | 2.08 MiB | 511.32 KiB |
| 771a432 | 1.58 MiB | 2.08 MiB | 511.32 KiB |
adinauer
reviewed
Jun 13, 2025
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Show resolved
Hide resolved
stefanosiano
commented
Jun 13, 2025
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Show resolved
Hide resolved
romtsn
reviewed
Jun 16, 2025
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
|
Hi, this is a feature I am quite keen on, so just dropping some useful (easy to add?) additions
|
Contributor
Author
|
hi @ishanzuaim, and thanks for the interest! You can already set the minimum logging level in the gradle plugin options following the logcat integration documentation We'll discuss how to best send the tag in the logs, too! |
# Conflicts: # CHANGELOG.md # sentry-android-core/src/test/java/io/sentry/android/core/InternalSentrySdkTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/SentryLogcatAdapterTest.kt
adinauer
approved these changes
Jul 4, 2025
Member
adinauer
left a comment
There was a problem hiding this comment.
Mostly LGTM, please check internally regarding attaching the stacktrace.
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Outdated
Show resolved
Hide resolved
…at/logcat-sentry-logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SentryLogcatAdapter now forwards output to Sentry Logs, if enabled
💡 Motivation and Context
Closes #4408
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps