Remove deprecations and inaccurate pin comment.#4383
Merged
runningcode merged 2 commits intomainfrom May 13, 2025
Merged
Conversation
The `pin@v3` comment is inaccurate beccause the current pin is part of v4. The commit of `v4.3.1` is `06832c7` see https://github.com/gradle/actions/releases/tag/v4.3.1. This also removes the `gradle-home-cache-cleanup` parameter since that now defaults to `true` in `v4`. See here: https://github.com/gradle/actions/blob/main/docs/deprecation-upgrade-guide.md#the-gradle-home-cache-cleanup-input-parameter-has-been-replaced-by-cache-cleanup
runningcode
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
stefanosiano
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
The
pin@v3comment is inaccurate beccause the current pin is part ofv4. The commit of
v4.3.1is06832c7see https://github.com/gradle/actions/releases/tag/v4.3.1.This also removes the
gradle-home-cache-cleanupparameter since thatnow defaults to
trueinv4. See here: https://github.com/gradle/actions/blob/main/docs/deprecation-upgrade-guide.md#the-gradle-home-cache-cleanup-input-parameter-has-been-replaced-by-cache-cleanup#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps