perf(breadcrumbs): Make SystemEventsBreadcrumbsIntegration faster#4330
Merged
perf(breadcrumbs): Make SystemEventsBreadcrumbsIntegration faster#4330
Conversation
romtsn
commented
Apr 11, 2025
| // in theory this should be ThreadLocal, but we won't have more than 1 thread accessing it, | ||
| // so we save some memory here and CPU cycles. 64 is because all intent actions we subscribe for | ||
| // are less than 64 chars. We also don't care about encoding as those are always UTF. | ||
| // TODO: _MULTI_THREADED_EXECUTOR_ |
Member
Author
There was a problem hiding this comment.
decided to mark things that depend on the single-threaded executor from now on so we won't shoot ourselves in the foot if we ever gonna switch to a multi-threaded one 😅
Contributor
Performance metrics 🚀
|
...ry-android-core/src/main/java/io/sentry/android/core/SystemEventsBreadcrumbsIntegration.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
The PR attempts to make
SystemEventsBreadcrumbsIntegrationfaster by:getStringAfterDotby using a pre-allocated buffer and iterating from the end of the string until the first dot to create a String after that. This yielded ~2x faster results on Android (10k iterations x 3 times):💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps