Use Implementation-Version as raw version#4291
Merged
Conversation
…-versions-android
Contributor
|
lcian
approved these changes
Mar 27, 2025
Member
lcian
left a comment
There was a problem hiding this comment.
Makes sense, so now Implementation-Version will be the release name right?
e.g. 8.0.0-rc1
Member
Author
Yes exactly, since this is a commonly used attribute in |
Member
Yeah I agree! |
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This mostly affects
sentry-opentelemetry-agentas it used to have a complex version string in theImplementation-Versionattribute of itsMANIFEST.MF(e.g.sentry-8.5.0-otel-2.10.0). We now use theSentry-Version-Nameattribute for the complex version instead and keepImplementation-Versionsimple, e.g.8.5.0.💡 Motivation and Context
Implementation-Versionis a common attribute and we should try to keep it simple. Also see https://docs.oracle.com/javase/tutorial/deployment/jar/packageman.html💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps