added platform to SentryEnvelopeItemHeader#4287
Merged
stefanosiano merged 4 commits intomainfrom Mar 26, 2025
Merged
Conversation
Added platform "android" in ProfileChunk envelope items
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 176d5ec | 399.08 ms | 518.53 ms | 119.45 ms |
| 61e8426 | 384.78 ms | 412.96 ms | 28.18 ms |
| 1421a3b | 426.76 ms | 462.20 ms | 35.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 176d5ec | 1.58 MiB | 2.22 MiB | 652.83 KiB |
| 61e8426 | 1.58 MiB | 2.22 MiB | 652.84 KiB |
| 1421a3b | 1.58 MiB | 2.22 MiB | 652.83 KiB |
markushi
approved these changes
Mar 26, 2025
| traceFile.getName()); | ||
| traceFile.getName(), | ||
| null, | ||
| "android"); |
Member
There was a problem hiding this comment.
I'm not sure if/how hybrid SDKs are using this, but should this always be "android"?
There was a problem hiding this comment.
The platform in the chunk item-type header should always match the platform in the chunk item-type payload.
So maybe instead of hard coding android, using profileChunk.getPlatform() could be better ?
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added
platformto SentryEnvelopeItemHeaderAdded platform "android" in ProfileChunk envelope items
💡 Motivation and Context
Implements client side of https://github.com/getsentry/team-ingest/issues/679
We want to rate limit UI and backend profile chunks differently.
In order to avoid having to maintain a list of sdk names, we are required to send the platform in the item header.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps