fix(replay): Change bitmap config to ARGB_8888 for screenshots#4282
Merged
fix(replay): Change bitmap config to ARGB_8888 for screenshots#4282
ARGB_8888 for screenshots#4282Conversation
romtsn
requested review from
adinauer,
lcian,
markushi and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
markushi
approved these changes
Mar 24, 2025
romtsn
added a commit
that referenced
this pull request
Mar 24, 2025
* fix(replay): Change bitmap config to ARGB_8888 for screenshots * Changelog
romtsn
added a commit
that referenced
this pull request
Mar 24, 2025
…) (#4283) * fix(replay): Change bitmap config to ARGB_8888 for screenshots * Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
An attempt to fix SIGSEGV which seems to be happening when we stop the replay after 30s the app has been backgrounded. I traced it down to this call which is where the exception
(SkColorInfo::operator=(SkColorInfo const&)+32)is happening. ThismInfois set from theBitmap.Configvalue that we pass upon constructing a bitmap. My theory is that it doesn't work well with theRGB_565config, especially when we're reusing the same bitmap to capture screenshots.Also it could be a combination of RN and some device vendors having tweaks to the AOSP code, not sure.
💡 Motivation and Context
Fixes #4228
💚 How did you test it?
no way to test this sadly as I couldn't reproduce on my devices
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps