Do not enable Sentry SDK for Android when mixed versions are detected#4271
Merged
Do not enable Sentry SDK for Android when mixed versions are detected#4271
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995f145 | 413.38 ms | 490.31 ms | 76.94 ms |
| d378e33 | 434.77 ms | 485.37 ms | 50.60 ms |
| d0ff1c3 | 445.58 ms | 509.68 ms | 64.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995f145 | 1.58 MiB | 2.21 MiB | 647.55 KiB |
| d378e33 | 1.58 MiB | 2.21 MiB | 647.55 KiB |
| d0ff1c3 | 1.58 MiB | 2.21 MiB | 647.55 KiB |
adinauer
commented
Mar 24, 2025
| .log( | ||
| SentryLevel.ERROR, | ||
| "Not initializing Sentry because mixed SDK versions have been detected."); | ||
| return false; |
Member
Author
There was a problem hiding this comment.
Changed in #4277 to cause an exception instead.
romtsn
approved these changes
Mar 24, 2025
Member
romtsn
left a comment
There was a problem hiding this comment.
LGTM, but do you want to remove the calls to addPackage from ctors/registers? I guess at this point they are all redundant
Member
Author
Yeah I can follow up with another PR to remove those. |
lcian
approved these changes
Mar 24, 2025
7 tasks
Member
Author
|
Removed duplicate calls to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Changelog entry is created in #4277
Parts of this PR are replaced in #4277 too
📜 Description
💡 Motivation and Context
Step 2 of solving #4132
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps