Assume http.client for span op if not a root span#4257
Merged
Conversation
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
lcian
approved these changes
Mar 13, 2025
| @SuppressWarnings("deprecation") | ||
| public @NotNull OtelSpanInfo extractSpanInfo( | ||
| final @NotNull SpanData otelSpan, final @Nullable IOtelSpanWrapper sentrySpan) { | ||
| if (!isInternalSpanKind(otelSpan)) { |
Member
There was a problem hiding this comment.
Could you explain why we removed this check?
Member
Author
There was a problem hiding this comment.
The problem we had before (see #3904) was that when span kind was set to neither CLIENT nor SERVER we would generate http as op (without .client or .server suffix).
The default span kind is INTERNAL. So if a customer manually instruments using OTel, doesn't set span kind and has HTTP span attributes set, the SpanDescriptionExtractor wouldn't know whether it's an incoming or outgoing request.
Having this check in place would prevent the changes in this PR from taking effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
When extracting span description, assume it's
http.clientif the span is not a root span (invalid or remote parent).💡 Motivation and Context
Fixes #3904
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps