Pass OpenTelemetry span attributes into TracesSampler callback#4253
Merged
Pass OpenTelemetry span attributes into TracesSampler callback#4253
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
lcian
reviewed
Mar 12, 2025
lcian
approved these changes
Mar 12, 2025
Member
lcian
left a comment
There was a problem hiding this comment.
Left some minor nits but LGTM.
We are calling it getAttribute which could possibly be an API we will have on Span as part of the attributes API that is in the works. As far as I understand this new concept of attributes will correspond to the OTEL one we are using here, so I agree on this naming.
Let's not forget to update the relevant docs: https://docs.sentry.io/platforms/java/guides/spring-boot/configuration/sampling/#setting-a-sampling-function
...telemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java
Show resolved
Hide resolved
Co-authored-by: Lorenzo Cian <lorenzo.cian@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SamplingContextnow has agetAttributemethod granting access to OpenTelemetry span attributes when Sentry is used in OpenTelemetry mode.💡 Motivation and Context
Fixes #4192
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps