Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f808d1 | 478.36 ms | 529.26 ms | 50.90 ms |
| 1c77f60 | 430.78 ms | 445.54 ms | 14.76 ms |
| 38b08c4 | 389.98 ms | 447.98 ms | 58.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6f808d1 | 1.58 MiB | 2.21 MiB | 642.09 KiB |
| 1c77f60 | 1.58 MiB | 2.21 MiB | 642.10 KiB |
| 38b08c4 | 1.58 MiB | 2.21 MiB | 642.21 KiB |
sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt
Outdated
Show resolved
Hide resolved
stefanosiano
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Makes span/breadcrumb data mutable, so we can update it whenever the underlying http request changes.
Unfortunately the okhttp
EventListeneralways gets the original request in most of it's callbacks, even though interceptors have changed the request already. Only when a response is received (e.g.responseHeadersStart()) theresponse.request.callwould contain the actual request, which probably isn't always called due to caching / errors, etc..Thus we need to wire the update logic into our interceptor instead - and assume it's running last in the chain.
💡 Motivation and Context
Fixes #3610
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps