Move cold app start detection and activity timespan generation back t…#4214
Closed
Move cold app start detection and activity timespan generation back t…#4214
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Move cold app start detection and activity timespan generation back t… ([#4214](https://github.com/getsentry/sentry-java/pull/4214))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
Member
Author
|
Closing in favor of #4216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Still a draft, but moves the duty of collecting Activity Spans and setting the app start type back to the ContentProvider. This allows us to collect performance data, even if the SDK itself is initialized async. E.g. for React Native where the first
Activity.onCreate()happens beforeSentryAndroid.init().💡 Motivation and Context
Fixes getsentry/sentry-react-native#4598
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
…o SentryPerformanceProvider