Add constructor to JUL SentryHandler for disabling external config#4208
Merged
Add constructor to JUL SentryHandler for disabling external config#4208
SentryHandler for disabling external config#4208Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
lcian
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add another constructor to
SentryHandlerthat allows passingenableExternalConfigurationto disable parsing of external configuration (by passingfalse). This defaults totruewhen using other constructors.💡 Motivation and Context
Came up in #4205 where Quarkus is trying to disable parsing of external config like
sentry.propertiesor ENV vars.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps