[SR] Fix crashes and add replay lifecycle management#4135
Merged
Conversation
Contributor
Performance metrics 🚀
|
romtsn
added a commit
that referenced
this pull request
Feb 7, 2025
|
@romtsn Was this included in the latest react-native release 6.7.0? It looks like it was added, but no new release triggered yet getsentry/sentry-react-native@80e955a |
Member
Author
|
@simonwh nope, 6.7.0 had been cut before this fix landed, we'll release a new patch version this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
FileNotFoundExceptionby checking for file existence and creating it before writingReplayLifecycleclass which tracks and manages the lifecycle of a running replay:pauseorresumemultiple timesaddOnDrawListenerinto a try-catch block as checking it for being alive was still not enough apparently (still got some crashes reported on it)💡 Motivation and Context
Closes getsentry/sentry-react-native#4498
Closes #4133
Closes getsentry/sentry#83352
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps