Merged
Conversation
…at/session-replay-recording-options
Contributor
Performance metrics 🚀
|
...-android-replay/src/test/java/io/sentry/android/replay/capture/SessionCaptureStrategyTest.kt
Show resolved
Hide resolved
vaind
reviewed
Dec 30, 2024
| assertEquals(true, optionsEvent[0].optionsPayload["maskAllText"]) | ||
| assertEquals(false, optionsEvent[0].optionsPayload["maskAllImages"]) | ||
| assertEquals("high", optionsEvent[0].optionsPayload["quality"]) | ||
| assertEquals("android.widget.TextView,android.webkit.WebView,android.widget.VideoView,androidx.media3.ui.PlayerView,com.google.android.exoplayer2.ui.PlayerView,com.google.android.exoplayer2.ui.StyledPlayerView,my.custom.View", optionsEvent[0].optionsPayload["maskedViewClasses"]) |
Contributor
There was a problem hiding this comment.
AFAIU from your definition of optionsPayload value, we could add a list here instead of a concatenated string. Would it make sense to do this by default so we can potentially have a better UI for this?
Member
Author
…at/session-replay-recording-options
Base automatically changed from
rz/feat/session-replay-override-sdk-version
to
main
December 30, 2024 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📜 Description
💡 Motivation and Context
Part of getsentry/sentry#74441
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
From the hybrid's side it's possible to intercept and change this event in their favour as follows: