-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update sidenav to scroll down to current page when necessary #16349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the sidebar navigation scroll behavior to automatically scroll the active link into view when necessary. The changes refactor the component from using a hardcoded aside element selector to dynamically finding the actual scrollable container, and adds automatic scrolling for the active link when there's no stored position (e.g., on page load or refresh).
Changes:
- Introduced a
findScrollContainerhelper function to dynamically locate the scrollable container instead of hardcodingasideelement lookups - Refactored both useEffect hooks to use the dynamic scroll container
- Added automatic scrolling behavior using
scrollIntoViewwhen no previous position is stored in sessionStorage - Wrapped the second useEffect's logic in
requestAnimationFrameto ensure DOM is fully rendered
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Bless you
DESCRIBE YOUR PR
Keeps the scroll depth of the nav in sync with the page you are on. See it on pages buried in the nav, e.g. https://sentry-docs-git-nav-scroll-update.sentry.dev/concepts/otlp/otlp-traces/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES