Skip to content

new (style): Updated contributing docs and Vale for style guide assistance#16267

Open
sfanahata wants to merge 2 commits intomasterfrom
style-guide-and-vale-linter
Open

new (style): Updated contributing docs and Vale for style guide assistance#16267
sfanahata wants to merge 2 commits intomasterfrom
style-guide-and-vale-linter

Conversation

@sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Feb 4, 2026

DESCRIBE YOUR PR

  • Updated contributing docs, agent.md, with a style guide and a reference to agent tools to help check.
  • Added Vale as an optional IDE tool to test out usefulness of prose formatting checks

Main preview: https://sentry-docs-git-style-guide-and-vale-linter.sentry.dev/contributing/approach/style-guide/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team
Cursor Bugbot found 1 potential issue for commit 3da955a

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Feb 4, 2026 11:20pm
sentry-docs Ready Ready Preview, Comment Feb 4, 2026 11:20pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

- Use "use" not "utilize"
- Verb forms: "set up" (verb) vs "setup" (noun), "log in" vs "login"

For the complete style guide, see: https://docs.sentry.io/contributing/approach/style-guide/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated style guide content between AGENTS.md and SKILL.md

Medium Severity

The new "Documentation Writing Style" section substantially duplicates content from .claude/skills/docs-review/SKILL.md. Both files contain nearly identical guidelines for Tone & Voice (Supportive Peer, Direct & Honest, Inclusive), Stylistic Rules (American English, Scannability, Active Voice, Headings), and Formatting (Code First, Bold for Emphasis). Consider having AGENTS.md reference the skill file or style-guide.mdx instead of duplicating the content.

Fix in Cursor Fix in Web


### Word Choice
- Use "blocklist/allowlist" not "blacklist/whitelist"
- Use "primary/replica" not "master/slave"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on the concept but primary/replica isn't developer parlance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants