feat(preprod): Add VCS parameters to snapshots upload command#3200
Merged
feat(preprod): Add VCS parameters to snapshots upload command#3200
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Add VCS parameters to snapshots upload command ([#3200](https://github.com/getsentry/sentry-cli/pull/3200))If none of the above apply, you can opt out of this check by adding |
rbro112
changed the title
rbro112
commented
Mar 10, 2026
| /// | ||
| /// When `auto_collect` is false, only explicitly provided values are collected; | ||
| /// automatic inference from git repository and CI environment is skipped. | ||
| pub fn collect_git_metadata( |
Member
Author
There was a problem hiding this comment.
No new logic in here, just extracted to be usable from both upload.rs and snapshots.rs
NicoHinderling
approved these changes
Mar 10, 2026
szokeasaurusrex
requested changes
Mar 10, 2026
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Requesting changes because vcs.rs should go under src/utils, not src/commands, as it breaks the pretty consistent pattern of each file under src/commands corresponding to a subcommand. We should also probably be reusing VcsInfo.
I've left some other comments, too, but those are less important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds vcs parameters to preprod snapshots upload command. Shares utilities with existing build upload command.
Issues
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.