build(ci): Remove unused dangerfile.js#1280
Open
runningcode wants to merge 1 commit into
Open
Conversation
This dangerfile has not run since #457 (March 2023) switched CI to the shared getsentry/github-workflows Danger workflow. That workflow executes its own bundled dangerfile, so the repo-local one was silently ignored. Changelog enforcement is already handled by the shared workflow (which requires an entry for feat/fix/perf/security PRs) together with craft's changelogPolicy: auto. Keeping a dead dangerfile that looks authoritative was misleading, so remove it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
romtsn
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo-local
dangerfile.jshas not been executed since #457 (March 2023), which switched CI to the sharedgetsentry/github-workflowsDanger workflow. That workflow runs its own bundled dangerfile:The only way to also run a repo-local dangerfile under v3 is the
extra-dangerfile:input, whichdanger.ymldoesn't set — so this file was dead code that misleadingly looked like the source of truth for changelog enforcement.Changelog enforcement is already covered by:
feat/fix/perf/security-flavored PRs (and exemptsbuild/ci/chore/docs/deps/etc. by design), andchangelogPolicy: autoin.craft.ymlplus thechangelog-previewworkflow.This brings the repo in line with sibling Sentry repos (e.g. sentry-java), which have no repo-local dangerfile.
🤖 Generated with Claude Code