Conversation
Member
|
I could swear this logic was necessary but seems like that is not the case indeed: https://docs.rs/multer/latest/multer/struct.Multipart.html#method.next_field |
tobias-wilfert
approved these changes
Apr 10, 2026
Member
tobias-wilfert
left a comment
tobias-wilfert
left a comment
There was a problem hiding this comment.
Maybe also have David have a look, just in case he sees a reason why this would still be needed.
Dav1dde
reviewed
Apr 10, 2026
Dav1dde
reviewed
Apr 13, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop reading to end of stream in
LimitedField- consuming an entire field before reading the next one is not necessary as multer already handles this internally.Ref: INGEST-830