ref(errors): Implements a new processor for errors#5633
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/error-processor
branch
3 times, most recently
from
5a176b4 to
2c407ae
Compare
Dav1dde
force-pushed
the
dav1d/error-processor
branch
from
2c407ae to
0d3fd0a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
jjbayer
approved these changes
Mar 4, 2026
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
Nice! I like the SentryError trait and the ErrorKind dispatch. I left a bunch of questions but IMO the only reason not to merge this would be the changed behavior for NSSwitch in the old pipeline.
I didn't look at the details of each subtype (minidump, unreal, etc.), but I assume the transformations are the same as before.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
process_errorsprocessing function to the new processing framework.The entire implementation is gated behind a feature flag.
All integration tests have by default the new feature flag enabled.