refactor: move feedback and upgrade under sentry cli command
#154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group CLI meta-commands under a new `cli` subcommand to avoid collision with the existing Sentry Feedback feature (user feedback on issues). Commands changed: - `sentry feedback` → `sentry cli feedback` - `sentry upgrade` → `sentry cli upgrade` - Removed `sentry update` alias
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
|
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 1964 uncovered lines. Files with missing lines (28)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 68.30% 69.39% +1.09%
==========================================
Files 55 56 +1
Lines 6395 6416 +21
Branches 0 0 —
==========================================
+ Hits 4368 4452 +84
- Misses 2027 1964 -63
- Partials 0 0 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
BYK
commented
Feb 2, 2026
test/commands/cli.test.ts
Outdated
Comment on lines
12
to
28
| describe("cliRoute", () => { | ||
| test("is exported and defined", () => { | ||
| expect(cliRoute).toBeDefined(); | ||
| }); | ||
| }); | ||
|
|
||
| describe("feedbackCommand", () => { | ||
| test("is exported and defined", () => { | ||
| expect(feedbackCommand).toBeDefined(); | ||
| }); | ||
| }); | ||
|
|
||
| describe("upgradeCommand", () => { | ||
| test("is exported and defined", () => { | ||
| expect(upgradeCommand).toBeDefined(); | ||
| }); | ||
| }); |
Member
Author
There was a problem hiding this comment.
These are silly tests. Use e2e tests for these.
Member
Author
|
Removed the trivial 'is exported and defined' tests as suggested. The file now only contains functional unit tests for command behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Group CLI meta-commands under a new
clisubcommand to avoid collision with the existing Sentry Feedback feature (user feedback on issues).Changes
Commands:
sentry feedback→sentry cli feedbacksentry upgrade→sentry cli upgradesentry updatealiasFiles:
src/commands/cli/withindex.ts,feedback.ts,upgrade.tssrc/app.tsto usecliRoutecommands/cli/, SKILL.md files)Breaking Changes
Users will need to use
sentry cli feedbackandsentry cli upgradeinstead of the old top-level commands.