Skip to content

Remove require#11689

Closed
jna4k wants to merge 3 commits intogeosolutions-it:masterfrom
jna4k:remove-require
Closed

Remove require#11689
jna4k wants to merge 3 commits intogeosolutions-it:masterfrom
jna4k:remove-require

Conversation

@jna4k
Copy link
Copy Markdown
Collaborator

@jna4k jna4k commented Nov 13, 2025

DRAFT - THIS PR IS STILL A DRAFT

I am still working on the PR, but there is still quite a bit of work left and I still need to do some more testing, but due to the amount of changes I thought it would put the PR up, even if its not quite ready for a review yet.

Description

We should change the codebase to use import/export instead of require.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Refactoring (no functional changes, no api changes)

Issue

What is the current behavior?

#11688

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa tdipisa linked an issue Nov 14, 2025 that may be closed by this pull request
1 task
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jan 20, 2026

@jna4k I notice this PR is open, still in draft, since mid November. If you don't have plans to update it and make it ready for review in the next few days I would like to close it so that you can reopen it when you have done. Thank you for your understanding.

@jna4k
Copy link
Copy Markdown
Collaborator Author

jna4k commented Jan 20, 2026

Hey, my intentions was to get back to this PR, but then the holidays and other stuff at work got in the way.

I still intend to finish what i started here, but unfortunately it will have to wait a while longer. For now I am okay with closing this PR, and I will make a new one, once the code is ready.

@jna4k jna4k closed this Jan 20, 2026
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jan 21, 2026

Hey, my intentions was to get back to this PR, but then the holidays and other stuff at work got in the way.

I still intend to finish what i started here, but unfortunately it will have to wait a while longer. For now I am okay with closing this PR, and I will make a new one, once the code is ready.

Thank you very much for your feedback and for your intention to finalize it. We are looking forward to receiving your updates as soon as possible. In the meantime, I would like to take this opportunity to ask you to visit the updated contributing rules in the project's WIKI where you can see info related to the CLA that is necessary for contributing updates to the MS core. Thank you so much again for your contribution in evolving MS and the MS community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace require with import/export

2 participants