-
Notifications
You must be signed in to change notification settings - Fork 444
Dynamic Legend for ARCGIS layers #11117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Legend for ARCGIS layers #11117
Conversation
…end' into arxit-floating-dynamic-legend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending issues:
- typo in
ArcGISLegend.jsxsee comment inline - missing unit tests for
Display.jsxandArcGISLegend.jsx - there is no message when the legend is empty. We should align the behavior as we already have in WMS Dynamic legend using
<Message msgId="layerProperties.legenderror" />when legend is empty
Correction of an apparent typo
Add units tests for ArcGISLegend.jsx Add units tests for Display.jsx
allyoucanmap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arxitpln This PR had only 3 files changes in the last review (master...0cd59de). Now it contains 44 files including files from other PRs DynamicLegend and LayersSelection.
This PR should only contain the files for the enhancement related to ArcGIS dynamic layers.
Could you please remove the files that are not part of this PR?
|
This pull is close and replaced by #11832 |
Description
"enableDynamicLegend" option for ARCGIS layers.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11113
What is the new behavior?
Option visible in the "Display" tab option
Effect visible in the TOC
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information