Skip to content

Conversation

@arxitpln
Copy link

@arxitpln arxitpln commented May 20, 2025

Description

"enableDynamicLegend" option for ARCGIS layers.

image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#11113

What is the new behavior?
Option visible in the "Display" tab option
Effect visible in the TOC

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending issues:

  • typo in ArcGISLegend.jsx see comment inline
  • missing unit tests for Display.jsx and ArcGISLegend.jsx
  • there is no message when the legend is empty. We should align the behavior as we already have in WMS Dynamic legend using <Message msgId="layerProperties.legenderror" /> when legend is empty
image

Correction of an apparent typo
@tdipisa tdipisa modified the milestones: 2025.02.00, 2026.01.00 Oct 10, 2025
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arxitpln This PR had only 3 files changes in the last review (master...0cd59de). Now it contains 44 files including files from other PRs DynamicLegend and LayersSelection.
This PR should only contain the files for the enhancement related to ArcGIS dynamic layers.
Could you please remove the files that are not part of this PR?

@arxitpln
Copy link
Author

arxitpln commented Dec 18, 2025

This pull is close and replaced by #11832

@arxitpln arxitpln closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Legend for ARCGIS layers

4 participants