Skip to content

add popup/ime check in editor #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qimiko wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −3
Open

add popup/ime check in editor #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e1a3e
add popup/ime check in editor
qimiko Feb 25, 2026
7567da0
fix propagate behavior
qimiko Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/EditorUI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,23 @@ struct $modify(EditorUI) {
return EditorUI::moveObjectCall(p0);
}

// popups are frequently in use, and we don't want keybinds to interfere with them
bool isTopLevel() {
if (CCIMEDispatcher::sharedDispatcher()->hasDelegate()) return false;

if (auto handler = static_cast<CCKeyboardHandler*>(CCKeyboardDispatcher::get()->m_pDelegates->lastObject())) {
// fix the pointer for comparison
return static_cast<CCKeyboardDelegate*>(this) == handler->m_pDelegate;
}

return true;
}

void defineKeybind(std::string id, CopyableFunction<bool(bool, bool, double)> callback) {
this->addEventListener(
KeybindSettingPressedEventV3(Mod::get(), std::move(id)),
[callback = std::move(callback)](Keybind const& keybind, bool down, bool repeat, double timestamp) {
[callback = std::move(callback), this](Keybind const& keybind, bool down, bool repeat, double timestamp) {
if (!isTopLevel()) return false;
return callback(down, repeat, timestamp);
}
);
Expand All @@ -285,8 +298,10 @@ struct $modify(EditorUI) {
void defineKeybind(std::string id, CopyableFunction<void(bool, double)> callback) {
this->addEventListener(
KeybindSettingPressedEventV3(Mod::get(), std::move(id)),
[callback = std::move(callback)](Keybind const& keybind, bool down, bool repeat, double timestamp) {
[callback = std::move(callback), this](Keybind const& keybind, bool down, bool repeat, double timestamp) {
if (down) {
if (!isTopLevel()) return ListenerResult::Propagate;

callback(repeat, timestamp);
return ListenerResult::Stop;
}
Expand All @@ -298,8 +313,10 @@ struct $modify(EditorUI) {
void defineKeybind(std::string id, CopyableFunction<void(double)> callback) {
this->addEventListener(
KeybindSettingPressedEventV3(Mod::get(), std::move(id)),
[callback = std::move(callback)](Keybind const& keybind, bool down, bool repeat, double timestamp) {
[callback = std::move(callback), this](Keybind const& keybind, bool down, bool repeat, double timestamp) {
if (!repeat && down) {
if (!isTopLevel()) return ListenerResult::Propagate;

callback(timestamp);
return ListenerResult::Stop;
}
Expand Down