Prepare release of 5.0.0 for willdurand/geocoder#1209
Merged
jbelien merged 9 commits intogeocoder-php:masterfrom Jan 1, 2025
Merged
Prepare release of 5.0.0 for willdurand/geocoder#1209jbelien merged 9 commits intogeocoder-php:masterfrom
jbelien merged 9 commits intogeocoder-php:masterfrom
Conversation
Member
|
I'll investigate the checks that are failing on PHP 8.2 but the tests for BingMaps seems to fail only on PHP 8.3.
|
Contributor
|
@jbelien I guess it was wrong all the time and just popped up with PHP 8.3. I did create a PR (see above) to solve this. |
Member
|
✅ We're back on track: #1220 |
Member
Author
|
I've rebased the PR. @jbelien please merge if you think we are ready. |
Chris53897
reviewed
Nov 29, 2024
jbelien
approved these changes
Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there anything else we should add here?
geocoder-php/php-common@4.6.0...master