[Photon] Reverse Geocoding with query filters

[ybert]

It can be usefull to search precise data from osm when we do reverse geocoding.

For example it can help to search only osm places (locality, city) from a location (latitude, longitude)

[jbelien]

Hello @ybert ,

Thanks a lot for your contribution.
I've looked a bit for documentation about query_string_filter but couldn't find anything. After a bit more research, I've found komoot/photon#703 (comment).

I see you've commented this issue but it seems that that filter was not really intended to be implemented and might be removed.

In theory we have the query_string_filter parameter for reverse which got sneaked in in komoot/photon#254. It should be able to do arbitrary filtering including the one you want. However, this was never documented and I very much prefer to let it die quietly and implement the tag filters from search instead.

I would prefer not to implement this feature in our provider (because we will have to remove it at some point which will create a breaking change) and instead implement osm_tag for the search (and the reverse geocoding once implemented).

[ybert]

Ok, I undersand your position.
Actually it is the only way to use reverse geocoding with photon and have specific result types.

I will see if I have time to propose a PR for osm_tag on the Photon repository.

[ybert]

Hello @jbelien,

My PR has just been merged in Photon master branch.

Can I implement geocoding and reverse with osm tags here or should I wait a tagged version in photon ?

[jbelien]

komoot/photon#742 has just been merged in Photon master branch.

Awesome work! 👍

Can I implement geocoding and reverse with osm tags here or should I wait a tagged version in photon ?

Of course, you can definitely already update this PR (or close this PR and open a new one if you prefer).

[ybert]

I just added osm tag feature for both geocode and reverse queries.

You can easily combine multiple osm tag filters like this :

$provider = new Geocoder\Provider\Photon\Photon($httpClient, 'https://your-photon-root-url');
$reverseQuery = \Geocoder\Query\GeocodeQuery::create('Paris')
    ->withData('osm_tag', ['tourism', ':!museum'])
    ->withLimit(5);
// Here we get 5 tourism results in Paris which are not museums
$results = $provider->reverseQuery($reverseQuery);

If it is ok for you I think we can safely release it as the feature has been released on Photon here https://github.com/komoot/photon/releases/tag/0.4.3

[ybert]

@jbelien Any chance to merge this PR ?

[ybert]

@jbelien Can we make a new release for the Photon provider to make these changes available ?

[jbelien]

@jbelien Can we make a new release for the Photon provider to make these changes available ?

Sure! But you need to merge your PR first! 😉

[ybert]

@jbelien How can I merge this PR ? I think I don't have write access.

[ybert]

@jbelien Let me know if there is anything I can do to get it merged ?

[jbelien]

@ybert My apologies, you indeed don't have the write to merge that PR. Taking care of it right now.