[POC] MapLibre layer #981
Draft
[POC] MapLibre layer #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
poc-maplibre-layer
|
| Run status |
|
| Run duration | 05m 14s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
38
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
DropdownButton.cy.ts • 1 failed test • component/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
Inputs.cy.ts • 1 failed test • component/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
TextSearchMarker.cy.ts • 1 failed test • component/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
TextTruncate.cy.ts • 1 failed test • component/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
pakb
force-pushed
the
poc-maplibre-layer
branch
from
9d4476d to
ea1d620
Compare
pakb
force-pushed
the
poc-maplibre-layer
branch
2 times, most recently
from
829e4e2 to
016cc8b
Compare
pakb
force-pushed
the
poc-maplibre-layer
branch
3 times, most recently
from
41e4b94 to
1925e79
Compare
pakb
added a commit
to pakb/ol-maplibre-layer
that referenced
this pull request
Jan 8, 2025
give the opportunity to translate the zoom level before giving it to MapLibre. This makes it possible to have OL functioning with a non-Mercator projection system, and still be able to have MapLibre receiving a valid Mercator zoom level to keep the maps in sync. You can see this code in action here : geoadmin/web-mapviewer#981 where we have our OL instance working in LV95.
pakb
force-pushed
the
poc-maplibre-layer
branch
from
1925e79 to
479db78
Compare
pakb
force-pushed
the
poc-maplibre-layer
branch
5 times, most recently
from
4c32505 to
d41c210
Compare
pakb
force-pushed
the
poc-maplibre-layer
branch
2 times, most recently
from
d8ded79 to
75c354f
Compare
pakb
force-pushed
the
poc-maplibre-layer
branch
4 times, most recently
from
36d5d70 to
0a8e960
Compare
pakb
force-pushed
the
poc-maplibre-layer
branch
from
468b890 to
cf589ad
Compare
each module now only exports one `*.d.ts` file at the root of its dist folder (thanks to @microsoft/api-extractor package, used by unplugin-dts) Use lib '@tmcw/togeojson' instead of mapbox equivalent as it comes with type definition for TS disabling TS option composite for mapviewer, as it breaks Vite alias import (`@/...`) when the TS compiler goes through a JS file. Keeping composite enabled on packages that are already 100% TS, as it works fine in this case
Renames and refactors coordinate utils to improve code organization and clarity. Adds new extent utilities for coordinate transformations, normalization, and intersection calculations. These changes lay the groundwork for improved coordinate handling and extent manipulation for our TS migration.
Makes it easier to update all lib in one go
also disabling composite on mapviewer package, it doesn't work well when allowJs is true (and with Vite's aliasing)
preparing the way to publish them on our newly created NPMJS registry account also removing the "id" from package names/folder
and share these configs throughout the monorepo. This is especially a great improvement for ESLint, which will now run in the scope of each package individually, instead of on the whole monorepo (type-checking took ages when running it like that) TS should also have a significant boost to perfs when developing in an IDE (as it doesn't think it should be running the whole monorepo at once anymore, each package is "self-contained")
PB-1383: Refactors coordinate utils and move extent utils there
- Issue 1: in the commands.ts file, we handled the booleans wrongly trying to add them to the viewer only if they were false instead of only when they are true, which is how it should be. - Issue 2: We changed the signature of the "goToMapView", and the test methods were using the old syntax Fix: We handle booleans correctly and changed the signature.
PB-1383: Fix cypress tests | 3d
- Issue: the `goToMapView` and `goToEmbedView` functions have had their signatures changed to use options as parameters, but tests were not changed to reflect those changes. - Fix: We changed the signature of all those functions.
PB-1383: change `goToView` signatures in cypress:
replaces all BG layers with a VectorTile equivalent switch to mercator as default projection to make it happen (not possible yet to mix projection systems, needs some work done on the geoblocks/ol-maplibre-layer library) fix INT staging URL : no sys service serves theses styles yet update to MapLibre 5.0.0 use dev env
pakb
force-pushed
the
poc-maplibre-layer
branch
from
7f9264e to
b735ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link