PB-2064: print cypress test #1532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerfe
force-pushed
the
fix-pb-2064-print
branch
4 times, most recently
from
31a1e57 to
1c3117c
Compare
sommerfe
changed the base branch from
feat-PB-1383-pinia-store
to
fix-pb-2026-fix-import-tool-file
sommerfe
force-pushed
the
fix-pb-2064-print
branch
from
1c3117c to
cada1cd
Compare
ismailsunni
force-pushed
the
fix-pb-2026-fix-import-tool-file
branch
from
313b278 to
06578d8
Compare
PB-2064: Fix geolocation test
Issue: the build could fail in some occasions because the features in kmlGeoJson.features.filter had an implicit `any` type, and the linter did not like that. Fix: We type the feature collection.
…turevalid PB-1383: typing the kmlGeoJson object
- Add validation checks before store assertions for non-CORS GPX import - Handle menu re-renders after layer removal with stabilization waits - Add conditional warning window handling - Move profile intercept setup before interactions
…after reload on the KML layer
When importing a KML file that is outside the extent, the parser was showing "Invalid file" error instead of the correct "out of bounds" error. The issue occurred because parseAll() threw the first rejected error from any parser, which was typically InvalidFileContentError from parsers that couldn't handle the file format. However, the KML parser correctly identified the file as KML and threw a more specific OutOfBoundsError. Fixed by prioritizing specific errors (OutOfBounds, Empty, UnknownProjection) over generic InvalidFileContentError, ensuring users see the most relevant error message.
When importing a KML file that is outside the extent, the parser was showing "Invalid file" error instead of the correct "out of bounds" error. The issue occurred because parseAll() threw the first rejected error from any parser, which was typically InvalidFileContentError from parsers that couldn't handle the file format. However, the KML parser correctly identified the file as KML and threw a more specific OutOfBoundsError. Fixed by prioritizing specific errors (OutOfBounds, Empty, UnknownProjection) over generic InvalidFileContentError, ensuring users see the most relevant error message.
sommerfe
force-pushed
the
fix-pb-2064-print
branch
from
b5490e9 to
1b6683a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link