PB-2064: attempt at fixing TS error while running Cypress on the CI #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-2064-fix-ts-error-in-tests
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
54
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
|
sommerfe
force-pushed
the
feat-PB-1383-pinia-store
branch
2 times, most recently
from
a1cccff to
9e6d8d7
Compare
pakb
force-pushed
the
fix-PB-2064-fix-ts-error-in-tests
branch
from
bd96796 to
b935ad0
Compare
I was able to reproduce some "process is not defined" error, and found out it was possibly linked to importing TS enums inside a Cypress test file. So I've removed some imports and replaced the enum values used by their string counterparts.
pakb
force-pushed
the
fix-PB-2064-fix-ts-error-in-tests
branch
from
1d27205 to
474fac4
Compare
I've some suspicion that Cypress' TS handling is struggling with our enum, so I wanted to test out one CI run without them. I've also re-ordered a bit some types from the API folder, and from the store. Icons and Features type are now in a dedicated file (I wanted to test if the import of the whole file was the problem with Cypress, and it looks better organized this way anyway, so why not keep it so) Store type files are also renamed index.ts, so the import of types looks a bit more logical (and shorter) I've locked pretter-plugin-jsdoc to the version 1.5.0 as the newer version creates some infinite loop issues
pakb
force-pushed
the
fix-PB-2064-fix-ts-error-in-tests
branch
from
9c13f2b to
f71c358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce some "process is not defined" error, and found out it was possibly linked to importing TS enums inside a Cypress test file. So I've removed some imports and replaced the enum values used by their string counterparts.
Test link