PB-2064: Fix import tool file #1516

ismailsunni · 2025-11-26T07:04:29Z

Some changes for fixing the tests:

Use ComputedRef as the parameter for useFieldValidation to maintain reactivity
Handling the KML and GPX more properly: attributions, kmlName, hasWarning
Prioritize errors from parsing
Fix intercepts, wrong layer menu id, etc

cypress · 2025-11-26T07:22:39Z

web-mapviewer Run #6210

Run Properties: Errored #6210 • 8fe2055b9c: PB-2026: Simplify error handling when importing KML file.

Project	`web-mapviewer`
Branch Review	`fix-pb-2026-fix-import-tool-file`
Run status	`Errored #6210`
Run duration	`27m 09s`
Commit	`8fe2055b9c: PB-2026: Simplify error handling when importing KML file.`
Committer	`Ismail Sunni`
View all properties for this run ↗︎

Test results
Failures	`31`
Flaky	`0`
Pending	`21`
Skipped	`0`
Passing	`155`
View all changes introduced in this branch ↗︎

Tests for review

drawing.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		`Test Replay` `Screenshots`

legacyParamImport.cy.ts • 10 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test on legacy param import > Layers import > Combines all old layers_*** params into the new one		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > is able to import an external KML from a legacy param		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > don't keep KML adminId in URL after import		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > doesn't show encoding in the search bar when serving a swisssearch legacy url		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > External WMS layer		`Test Replay` `Screenshots`
Test on legacy param import > Layers import > External WMTS layer		`Test Replay` `Screenshots`
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only heading		`Test Replay` `Screenshots`
Test on legacy param import > Extra Parameter Imports > shows the compare slider at the correct position		`Test Replay` `Screenshots`

timeSlider.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		`Test Replay` `Screenshots`

3d/layers.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		`Test Replay` `Screenshots`

layers.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		`Test Replay` `Screenshots`

The first 5 failed specs are shown, see all 16 specs in Cypress Cloud.

Copilot

Pull request overview

This PR fixes issues with the import tool file functionality, including improvements to layer ID handling, validation reactivity, error message prioritization, and test stability.

Key changes:

Added KML| and GPX| prefixes to layer IDs throughout the application for consistent layer identification
Refactored validation composable to use ComputedRef<props> for better reactivity
Improved error prioritization in file parsers to show more specific errors (OutOfBounds, Empty, UnknownProjection) over generic errors

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/viewer/tests/cypress/tests-e2e/importToolFile.cy.ts	Updated test expectations to match new layer ID format with `KML\|` and `GPX\|` prefixes; improved test stability with proper wait conditions; refactored 3D test into separate skipped test; added profile intercept constant
packages/viewer/src/utils/composables/useFieldValidation.ts	Changed props parameter from object to `ComputedRef` for proper reactivity; updated to emit full `ValidationResult` object instead of boolean; removed unused `toRef` import
packages/viewer/src/utils/components/TextInput.vue	Converted `validationProps` to computed ref for consistency with updated composable
packages/viewer/src/utils/components/TextAreaInput.vue	Converted `validationProps` to computed ref for consistency with updated composable
packages/viewer/src/utils/components/FileInput.vue	Converted `validationProps` to computed ref; updated default prop values and parameter handling; added `computedRequired` usage
packages/viewer/src/utils/components/EmailInput.vue	Converted `validationProps` to computed ref for consistency with updated composable
packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/index.ts	Implemented error prioritization logic to show specific errors (OutOfBounds, Empty, UnknownProjection) before generic InvalidFileContentError
packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/KMLParser.class.ts	Added KML name parsing and proper layer initialization with `name`, `hasWarning`, and `isLoading` properties
packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/GPXParser.class.ts	Added `gpxFileUrl` parameter to layer creation for proper GPX layer initialization
packages/viewer/src/modules/menu/components/advancedTools/ImportFile/ImportFileOnlineTab.vue	Fixed loading state handling by removing delayed timeout and setting state immediately; reordered props for clarity
packages/viewer/src/modules/menu/components/advancedTools/ImportFile/ImportFileLocalTab.vue	Added `validMarker` prop to FileInput for consistent validation feedback
packages/layers/src/utils/layerUtils.ts	Added automatic attribution generation based on file source (local files use filename, URLs use hostname); improved `isLocalFile` detection; added error handling for URL parsing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot · 2025-12-01T04:09:22Z

packages/viewer/tests/cypress/tests-e2e/importToolFile.cy.ts

        cy.reload()
        cy.waitMapIsReady()
+
+        // TODO(IS): We shoudl check for warnings about missing local files, but it needs to be fixed first (related to url)


Typo in comment: "shoudl" should be "should"

Suggested change

// TODO(IS): We shoudl check for warnings about missing local files, but it needs to be fixed first (related to url)

// TODO(IS): We should check for warnings about missing local files, but it needs to be fixed first (related to url)

pakb

I think there might be some conflicting changes with something I've worked on on the report a problem fix, I'll double check that and come with a solution

packages/layers/src/utils/layerUtils.ts

packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/index.ts

packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/KMLParser.class.ts

packages/viewer/src/modules/menu/components/advancedTools/ImportFile/ImportFileOnlineTab.vue

packages/viewer/src/utils/components/EmailInput.vue

…s and simplify composable

…on props

- Add validation checks before store assertions for non-CORS GPX import - Handle menu re-renders after layer removal with stabilization waits - Add conditional warning window handling - Move profile intercept setup before interactions

…after reload on the KML layer

When importing a KML file that is outside the extent, the parser was showing "Invalid file" error instead of the correct "out of bounds" error. The issue occurred because parseAll() threw the first rejected error from any parser, which was typically InvalidFileContentError from parsers that couldn't handle the file format. However, the KML parser correctly identified the file as KML and threw a more specific OutOfBoundsError. Fixed by prioritizing specific errors (OutOfBounds, Empty, UnknownProjection) over generic InvalidFileContentError, ensuring users see the most relevant error message.

github-actions bot added the bug label Nov 26, 2025

ismailsunni changed the title ~~Fix pb 2026 fix import tool file~~ PB-2026: Fix import tool file Nov 26, 2025

ismailsunni force-pushed the fix-pb-2026-fix-import-tool-file branch 6 times, most recently from b0e473a to abde6f8 Compare December 1, 2025 04:05

ismailsunni requested a review from Copilot December 1, 2025 04:06

ismailsunni changed the title ~~PB-2026: Fix import tool file~~ PB-2064: Fix import tool file Dec 1, 2025

Copilot started reviewing on behalf of ismailsunni December 1, 2025 04:06 View session

Copilot finished reviewing on behalf of ismailsunni December 1, 2025 04:09

ismailsunni marked this pull request as ready for review December 1, 2025 04:09

ismailsunni requested a review from pakb December 1, 2025 04:09

Copilot AI reviewed Dec 1, 2025

View reviewed changes

sommerfe force-pushed the feat-PB-1383-pinia-store branch 2 times, most recently from a1cccff to 9e6d8d7 Compare December 2, 2025 08:43

ismailsunni force-pushed the fix-pb-2026-fix-import-tool-file branch 2 times, most recently from 4d63ddb to 327e625 Compare December 8, 2025 12:35

pakb reviewed Dec 10, 2025

View reviewed changes

sommerfe force-pushed the fix-pb-2026-fix-import-tool-file branch from 327e625 to f9cd5c5 Compare December 10, 2025 15:34

ismailsunni force-pushed the fix-pb-2026-fix-import-tool-file branch from 8fe2055 to 313b278 Compare December 15, 2025 04:32

ismailsunni added 7 commits December 16, 2025 09:56

PB-2064: Fix the wrong emit value.

5b2b830

PB-2064: Fix missing success message.

c8d4840

PB-2064: Better solution without withDefaults.

68e80f5

PB-2064: Accept computed props.

19dbab8

PB-2064: Use simpler way to handle not provided prop.

4976863

PB-2064: Use the same approach for FileInput as in TextInput.

0e8ebe0

PB-2064: Unify field validation: use computed props in both component…

d9320ca

…s and simplify composable

ismailsunni added 19 commits December 16, 2025 09:56

PB-2064: Update TextAreaInput and EmailInput to use computed validati…

33a50da

…on props

PB-2064: Fix coordinate typo and timing issues

3dffe45

- Add validation checks before store assertions for non-CORS GPX import - Handle menu re-renders after layer removal with stabilization waits - Add conditional warning window handling - Move profile intercept setup before interactions

PB-2064: Fix KML name and some tests.

91921ba

PB-2064: Fix failed test on KML: KML layer id, hasWarning

0cf0327

PB-2064: Fix missing attribution on KML Layer.

04d7ccf

PB-2064: Fix test on KML layer's buttons

51d0ffa

PB-2064: Spliting some test for easier fix. Skip 3D test and warning …

ccbc854

…after reload on the KML layer

PB-2064: Partially fix on KML error handling, due to different layer id.

109c662

PB-2064: Fix TS type error.

df861d6

PB-2064: Extract GPX profile error test into separate test block

d8f7500

PB-2064: Add another goToMapView to fix cypress running issue in the CI.

fb44c6c

PB-2064: Fix import KML file error handling after rebase.

d3e01a1

PB-2064: don't use force true to fix failed test after rebase.

f632af4

PB-2064: No force true on click to fix the failed test.

1c17543

PB-2026: Put isLoading false in finally in case something is wrong.

9c7bf71

PB-2026: Use better check for isLocalFile.

9633e33

PB-2026: Move hasWarning and isLoading to the makeKMLLayer function.

d858bb7

PB-2026: Simplify error handling when importing KML file.

06578d8

ismailsunni force-pushed the fix-pb-2026-fix-import-tool-file branch from 313b278 to 06578d8 Compare December 16, 2025 02:56

ismailsunni mentioned this pull request Dec 24, 2025

PB-2064: Fix Import Tool File Test #1544

Open

ismailsunni closed this Dec 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PB-2064: Fix import tool file #1516

PB-2064: Fix import tool file #1516

Uh oh!

ismailsunni commented Nov 26, 2025 •

edited

Loading

Uh oh!

cypress bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

pakb left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// TODO(IS): We shoudl check for warnings about missing local files, but it needs to be fixed first (related to url)
	// TODO(IS): We should check for warnings about missing local files, but it needs to be fixed first (related to url)

PB-2064: Fix import tool file #1516

PB-2064: Fix import tool file #1516

Uh oh!

Conversation

ismailsunni commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cypress bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

web-mapviewer Run #6210

Tests for review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

pakb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ismailsunni commented Nov 26, 2025 •

edited

Loading

cypress bot commented Nov 26, 2025 •

edited

Loading