Open
Conversation
Change "How It Works" to better distinguish between the probe and download steps. provided by @CaptainInler
Contributor
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
I like the overview given at the beginning. I would at least fix the typo ("this --> "these") or rephrase certain certain parts for clarity 🙃
| The workaround is to use **HTTP range requests**, which bypass the CloudFront limit by fetching the file in sequential chunks directly from the S3 origin. | ||
|
|
||
| ## How It Works | ||
| The actual download is completed in this steps: |
Contributor
There was a problem hiding this comment.
🤔 Not sure I understand this sentence. Also, it is usually clearer to use active voice instead of passive.
How about this instead?
Suggested change
| The actual download is completed in this steps: | |
| Downloading a large asset involves three steps that we detail in the following subsections: |
|
|
||
| You can probe an asset manually with `curl`: | ||
| Example to probe an asset manually with `curl` on Linux: | ||
|
|
Contributor
There was a problem hiding this comment.
Why "on Linux"? In my understanding, curl is also available on Windows.
| ::: | ||
|
|
||
| ## Download Script | ||
| ## Download |
Contributor
There was a problem hiding this comment.
I find it confusing that the first title follows what is written in the list and the second does not
The list:
- Probe the asset
- Download the file in chunks
- Optional: Verify SHA‑256 checksum
The titles:
## Probe the asset
## DownloadHow about making the titles consistent with the list?
## 1. Probe the asset
## 2. Download the file in chunks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change "How It Works" to better distinguish between the probe and download steps.
provided by @CaptainInler
Test link