[ENH] Improve fault handling in dual contouring with arbitrary grid shapes and conservative triangle removal #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors for anisotropic grid shapes - Replaced single base number with separate `base_x`, `base_y`, `base_z` for flexibility - Adjusted `_get_pack_factors` to compute packing factors based on individual grid dimensions - Improved handling of empty `left_right_array` by initializing grid dimensions to zero
…s (`base_x`, `base_y`, `base_z`) - Updated triangulation logic to use individual grid dimension values for improved flexibility. - Adjusted `check_voxels_exist_next_to_edge` to handle separate dimension values in edge validation. - Removed redundant calculation of `base_number`.
…odes` Cleaned up deprecated logic and comments to improve code readability and maintainability.
- Eliminated `_last_pass` function and associated logic from `dual_contouring_v2` to simplify processing. - Updated test with consistent random seed for reproducibility. - Adjusted grid shape in test configuration for clarity.
Updated `regular_grid_shape` in the test setup to `[5, 2, 4]` for better alignment with current test requirements.
Introduced a two-step process for mesh overlap handling: vertex sharing followed by conservative triangle removal. Enhanced `_remove_triangles_in_voxels` function to support a new 'all' mode for selective triangle removal. Updated grid logic and test configurations to align with refined octree methods and model data structures.
Leguark
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve triangulation for anisotropic grid shapes and refine mesh overlap handling
Triangulation Improvements
base_x,base_y,base_zdimensions_get_pack_factorsto compute packing factors based on individual grid dimensionsleft_right_arrayby initializing grid dimensions to zeroMesh Overlap Handling Enhancements
_remove_triangles_in_voxelsfor selective triangle removalCode Cleanup and Testing
_last_passfunction and associated logic[5, 2, 4]for better testingThese changes improve the handling of complex geological structures with anisotropic grid shapes and provide more precise control over mesh generation at fault intersections.