Skip to content

Add simple terraform pipeline eval#140

Merged
haroonc merged 2 commits intogemini-cli-extensions:evalsfrom
kmontg:evals
Apr 16, 2026
Merged

Add simple terraform pipeline eval#140
haroonc merged 2 commits intogemini-cli-extensions:evalsfrom
kmontg:evals

Conversation

@kmontg
Copy link
Copy Markdown
Collaborator

@kmontg kmontg commented Apr 15, 2026

This adds a simple eval for testing the pipeline design skill when the user asks for Terraform and Cloud Deploy to be used.

Static assertions check for a cloudbuild.yaml file with test, build, push and deploy steps and a check that the created terraform is valid, and contains resources that are expected for this type of deployment. We may want to improve these checks in the future.

Note that this eval is quite flaky, as often the expected skills are not triggered. We can use this to drive improvements to the skill definitions so that they are applied more consistently.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic resource naming for evaluation tasks, updates cleanup and validation scripts to handle these names as arguments, and adds a new evaluation task for designing CI/CD pipelines using Terraform. Feedback highlights potential issues in the new validation scripts, specifically regarding the fragility of using grep for YAML and Terraform plan analysis, the lack of variable handling in Terraform validation, and the removal of explicit project flags in GCS cleanup which could lead to environment-dependent failures.

Comment thread scripts/validate-terraform-simple-pipeline.sh
Comment thread scripts/validate-terraform-simple-pipeline.sh
Comment thread scripts/teardown-gcs.sh Outdated
Comment thread scripts/validate-cloudbuild-simple-pipeline.sh Outdated
@haroonc haroonc merged commit 8deaf4a into gemini-cli-extensions:evals Apr 16, 2026
2 checks passed
@kmontg kmontg deleted the evals branch April 17, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants