-
Notifications
You must be signed in to change notification settings - Fork 27
refactor: Improve DevX #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Karrq
wants to merge
65
commits into
develop
Choose a base branch
from
refactor/devex
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(build:docker): quiet invocations
feat: justfile doctor (system dependencies check)
refactor(gateway): external env config
feat(spamoor): migrate spamoor start script
Collaborator
|
@claude plz review |
feat: overseer refactor: other-logs -> logs feat: start/stop/logs component
Collaborator
Author
|
There are some things I'd like to clarify to improve this further:
|
fix: typos
fix: public-ip perf: public-ip
fix(ci): prepare checks full config
fix(test): defaults for env variables
feat(ci): restore wallets from backup
fix(make): correct defaults for L1 RPCs fix(deploy): set chain cfg folder permissions
fix(build): parallel thru just, hash recipe
fix(ci): more portable test ports
fix: configurable PORTAL_PORT
fix(scripts): display existing wallet address with ensure
Contributor
|
Commit dcf5bb2 seems to break the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to improve the DevX by providing a more streamlined set of scripts to setup and start testing the environment locally, but also aid during first checkout, by fetching all required external dependencies, not otherwise present in the repo.
NOTE: Originally the PR moved rabby from the root to
deps/rabbyfor consistency, but that exploded the number of changed files. So this PR still has the assumption that rabby lives indeps/rabby, but the rabby fork will be moved in a separate PR.TODO: