Feature/code inspections#1350
Merged
garris merged 4 commits intogarris:masterfrom Aug 11, 2021
klodoma:feature/code-inspections
Merged
Feature/code inspections#1350garris merged 4 commits intogarris:masterfrom klodoma:feature/code-inspections
garris merged 4 commits intogarris:masterfrom
klodoma:feature/code-inspections
Conversation
Contributor
|
I would like to see that in the next major version, maybe also with some git hooks implemented to force codestyle. For my pullrequest I tried to keep the current code-style, to make it easier to merge/read... |
garris
approved these changes
Aug 11, 2021
Owner
garris
left a comment
garris
left a comment
There was a problem hiding this comment.
Thank you -- nice cleanup work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This is only about code formatting, getting rid of several warnings in the editor.
I haven't checked all of them, first I would like to get a feedback if this direction is OK or NOT.