feat: Port exportLibs.py script to python-gardenlinux-lib#253
Closed
feat: Port exportLibs.py script to python-gardenlinux-lib#253
exportLibs.py script to python-gardenlinux-lib#253Conversation
NotTheEvilOne
requested changes
Nov 14, 2025
Contributor
|
Looks good so far now. Could you please add some unit tests to check for the command line tool to actually produce the result you are expecting? |
Contributor
Author
|
I've added a test for the exporter. A test for the entire setup is also contained in #3914. I think testing the main program explicitly is not necessary. |
NotTheEvilOne
approved these changes
Nov 25, 2025
Contributor
NotTheEvilOne
left a comment
There was a problem hiding this comment.
Small change, otherwise looks good for me :)
Contributor
Author
|
Thank you :) Have you seen Florians message regarding this on Slack? |
Contributor
Unfortunately I've no access to Slack at the moment. |
Contributor
Author
|
I've created a Teams group, hope you can access it |
Contributor
Author
|
Closing due to ADR 30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
exportLibs.pyscript from feat: add container-python-dev for multi-stage builds gardenlinux#3695 in python-gardenlinux-libUsage: (updated)
Special notes for your reviewer:
Feel free to criticise a lot, this is my first contribution to python-gardenlinux-lib. I also do not know which version to put into the docstrings