Conversation
76cd00a to
dd180df
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 92.37% 92.36% -0.01%
==========================================
Files 40 40
Lines 1822 1821 -1
==========================================
- Hits 1683 1682 -1
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fixes passing of None value to non-noneable parameters in filter function
26780c3 to
bf24225
Compare
yeoldegrove
approved these changes
Oct 15, 2025
Contributor
yeoldegrove
left a comment
There was a problem hiding this comment.
Changes look ok to me. Good to merge if the linting errors are fixed.
Contributor
Author
The current CI failure is a result of errors in other modules. I'm going module by module, next one is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes various typing and some smaller logic issues within the
featuresmodule.Fixes include:
RuntimeErrorbefore calling any filter function ifflavorisNoneto avoid passingNonevaluesValueErrorin theParserclassOptionaltype hints in cases where default values are setCallablein function signaturesnetworkx.DiGraphin the_exclude_from_filter_setfunction to avoid accessingsuccessorsofUnknowntypeWhile doing these fixes, I noticed that many values are initialized as
Noneand then treated like a regularstrtype in the code that follows. I tried to assume the most logical approach to determine if these values are allowed to beNonein their respective context.Todo:
flavorvariable in__main__.pywithout proper handlingWhich issue(s) this PR fixes:
Tracks #152