Skip to content

Apply Fix to Layer class methods correctly#167

Merged
ByteOtter merged 1 commit intomainfrom
fix/fix-layer-methods
Aug 13, 2025
Merged

Apply Fix to Layer class methods correctly#167
ByteOtter merged 1 commit intomainfrom
fix/fix-layer-methods

Conversation

@ByteOtter
Copy link
Contributor

What this PR does / why we need it:

Places the else block in __delitem__() properly instead of __getitem__()

Which issue(s) this PR fixes:
Fixes n/A

Special notes for your reviewer:

Release note:

bugfix developer
* Fix misplaced else block in __getitem__() and moves it to __delitem__() to fix always raising KeyError

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.23%. Comparing base (4729eb7) to head (537f2c2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/oci/layer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          27       27           
  Lines        1226     1226           
=======================================
  Hits         1045     1045           
  Misses        181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ByteOtter ByteOtter changed the title Fix/fix layer methods Apply Fix to Layer class methods correctly Aug 13, 2025
@ByteOtter ByteOtter merged commit 39f7529 into main Aug 13, 2025
10 of 11 checks passed
@ByteOtter ByteOtter deleted the fix/fix-layer-methods branch August 13, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants