CI: Improve actions/setup workflow#156
Conversation
NotTheEvilOne
left a comment
There was a problem hiding this comment.
We should support outputs for this action. E.g.:
outputs:
cache_type:
description: "Detected Python cache strategy."
value: ${{ steps.lockfile.outputs.cache_type }}
* Check for existing python installation before installing new * Base caching method on found lockfile type
eb7c16d to
967d5ef
Compare
* Format Code * Combine cache type evaluation and installation verification into one * Expose cache_type as output to invoked actions
Did just that with the latest commit. |
|
If I remember correctly each GitHub runner has an |
|
Hmm I think in that case we should remove that skipping of |
|
Currently encountering this error right here: Which means that at the point |
|
Different from |
57391bf to
d3a8901
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 63.00% 63.00%
=======================================
Files 27 27
Lines 1192 1192
=======================================
Hits 751 751
Misses 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
d3a8901 to
8759217
Compare
What this PR does / why we need it:
Expands the existing
setupactions with logic that skips python installation when python is already installed and sets the caching method depending on the lockfile type (pipforrequirements.txtandpoetryforpoetry.lock; If no lockfile is found, an emptyrequirements.txtis created and caching type set topip)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: