feat: configure S3 upload metadata based on {cname}.requirements file#151
Merged
NotTheEvilOne merged 4 commits intomainfrom Aug 4, 2025
Merged
feat: configure S3 upload metadata based on {cname}.requirements file#151NotTheEvilOne merged 4 commits intomainfrom
NotTheEvilOne merged 4 commits intomainfrom
Conversation
NotTheEvilOne
requested changes
Jul 31, 2025
NotTheEvilOne
approved these changes
Jul 31, 2025
… instead of hardcoded feature mappings
also add fallback to feature based decision if no .requirements file or if keys are missing in order to provide backwards compatibility
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
feat/requirements
branch
from
5e76c2b to
79be8d1
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use info provided by the
{cname}.requirementsfile introduced by gardenlinux/builder#121 instead of relying on hardcoded feature mappings.Caution
This will require both merging the builder PR and a subsequent update of the builder used in gardenlinux before we can merge this.
Also there are considerations wether this might cause issues with backwards compatibility when using this lib with patch releases for previous versions. @NotTheEvilOne I'd appreciate your input on this, wether we can merge this or if it would have unintended side effects like that.