a missing features for GLRD and gardenlinux's tests#132
Conversation
2c2d551 to
482b235
Compare
NotTheEvilOne
left a comment
There was a problem hiding this comment.
Thanks for the changes @yeoldegrove. Do you mind splitting this PR for:
- "GitHub" functionality
- S3 extension
5cfa3e4 to
0eb399f
Compare
0eb399f to
b676dd1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 72.73% 73.32% +0.59%
==========================================
Files 27 27
Lines 1192 1226 +34
==========================================
+ Hits 867 899 +32
- Misses 325 327 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
31eec24 to
70f4673
Compare
be67932 to
b0fd8ca
Compare
b0fd8ca to
e273982
Compare
ByteOtter
left a comment
There was a problem hiding this comment.
lgtm so far, most gripes I have are nitpicks about code style that we can address later with CI.
Only thing I would like to have changed is the name of the test function in test_bucket as its currently not being executed as far as I see because pytest can't detect it without the test_ prefix.
Fell free to treat all other comments as optional.
|
When it comes to other test coverage, I can bring that back up later :) |
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
5a6e0cc to
38a968d
Compare
Removing review as during absence I took over @yeoldegrove work and it looks like I can't remove the "request changes" status of the first review otherwise.
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
38a968d to
01fda54
Compare
ByteOtter
left a comment
There was a problem hiding this comment.
While the handling of file operations causes me a slight tummy ache. I trust your judgement and approve this.
Maybe we can revisit this later.
What this PR does / why we need it:
In the latest refactoring a few features got lost that GLRD and gardenlinux's tests are currently depending on.
This PR adds those features back: