Draft
Conversation
F401 - Unused imports: Removed atexit, base64, re, time, json, and pathlib.Path F403/F405 - Star imports: Replaced all from module import * with explicit imports: glrd.util: Now imports specific symbols like DEFAULTS, ERROR_CODES, etc. python_gardenlinux_lib: Now imports specific functions like parse_flavors_commit, get_s3_artifacts F841 - Unused variables: Fixed unused variables like minor, micro, e, merged_releases, formatted_change F541 - F-strings without placeholders: Converted f-strings to regular strings where no placeholders were used F811 - Redefinition: Fixed variable redefinitions F821 - Undefined names: Fixed test cases where result was being used but assigned to _ F824 - Unused global: Commented out unused global variable E303 - Extra blank lines: Fixed excessive blank lines E501 - line too long
yeoldegrove
force-pushed
the
feat/bump_python_gardenlinux_lib
branch
2 times, most recently
from
e5121c4 to
f911488
Compare
yeoldegrove
force-pushed
the
feat/bump_python_gardenlinux_lib
branch
from
f911488 to
28a7960
Compare
yeoldegrove
force-pushed
the
feat/bump_python_gardenlinux_lib
branch
from
28a7960 to
16cd1c4
Compare
yeoldegrove
changed the title
yeoldegrove
force-pushed
the
feat/bump_python_gardenlinux_lib
branch
from
16cd1c4 to
4e3988d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactor to work with gardenlinux 0.10.0.