Skip to content

Widen declaration for many matrix related functions #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fingolfin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Widen declaration for many matrix related functions #6095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e56f7
Widen declaration for many matrix related functions
fingolfin Sep 4, 2025
e1105b7
make a manual example more robust
ThomasBreuer Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/ctblmono.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,13 +350,12 @@ DeclareProperty( "IsPrimitiveCharacter", IsClassFunction );
## rec( comment := "all restrictions checked", isQuasiPrimitive := true )
## gap> chi:= Irr( Sl23 )[7];
## Character( CharacterTable( SL(2,3) ), [ 3, 0, 0, 3, 0, 0, -1 ] )
## gap> TestQuasiPrimitive( chi );
## rec( character := Character( CharacterTable( Group(
## [ [ [ 0*Z(3), Z(3) ], [ Z(3)^0, 0*Z(3) ] ],
## [ [ Z(3), 0*Z(3) ], [ 0*Z(3), Z(3) ] ],
## [ [ Z(3)^0, Z(3) ], [ Z(3), Z(3) ] ] ]) ),
## [ 1, -1, 1, -1, 1 ] ), comment := "restriction checked",
## isQuasiPrimitive := false )
## gap> test:= TestQuasiPrimitive( chi );;
## gap> test.isQuasiPrimitive; test.comment;
## false
## "restriction checked"
## gap> ValuesOfClassFunction( test.character );
## [ 1, -1, 1, -1, 1 ]
## ]]></Example>
## </Description>
## </ManSection>
Expand Down
16 changes: 0 additions & 16 deletions lib/matobjnz.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,14 +1353,6 @@ InstallMethod( InverseSameMutability, "for a zmodnz matrix",
return n;
end );

InstallMethod( RankMat, "for a zmodnz matrix", [ IsZmodnZMatrixRep ],
function( m )
m:=MutableCopyMatrix(m);
m:=SemiEchelonMatDestructive(m);
if m<>fail then m:=Length(m.vectors);fi;
return m;
end);


#InstallMethodWithRandomSource( Randomize,
# "for a random source and a mutable zmodnz matrix",
Expand Down Expand Up @@ -1489,14 +1481,6 @@ InstallMethod( CompatibleVector, "for a zmodnz matrix",
return NewZeroVector(IsZmodnZVectorRep,BaseDomain(v),NumberRows(v));
end );

InstallMethod( DeterminantMat, "for a zmodnz matrix", [ IsZmodnZMatrixRep ],
function( a )
local m;
m:=Size(BaseDomain(a));
a:=List(a![ROWSPOS],x->x![ELSPOS]);
return ZmodnZObj(DeterminantMat(a),m);
end );


# Minimal/Characteristic Polynomial stuff
#############################################################################
Expand Down
78 changes: 39 additions & 39 deletions lib/matrix.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ DeclareSynonym( "DiagonalOfMat", DiagonalOfMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "BaseMat", IsMatrix );
DeclareAttribute( "BaseMat", IsMatrixOrMatrixObj );

#############################################################################
##
Expand All @@ -222,7 +222,7 @@ DeclareAttribute( "BaseMat", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "BaseMatDestructive", [ IsMatrix ] );
DeclareOperation( "BaseMatDestructive", [ IsMatrixOrMatrixObj ] );

#############################################################################
##
Expand All @@ -244,7 +244,7 @@ DeclareOperation( "BaseMatDestructive", [ IsMatrix ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "BaseOrthogonalSpaceMat", IsMatrix );
DeclareAttribute( "BaseOrthogonalSpaceMat", IsMatrixOrMatrixObj );


#############################################################################
Expand All @@ -271,7 +271,7 @@ DeclareAttribute( "BaseOrthogonalSpaceMat", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "DefaultFieldOfMatrix", IsMatrix );
DeclareAttribute( "DefaultFieldOfMatrix", IsMatrixOrMatrixObj );


#############################################################################
Expand All @@ -295,7 +295,7 @@ DeclareAttribute( "DefaultFieldOfMatrix", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "DepthOfUpperTriangularMatrix", IsMatrix );
DeclareAttribute( "DepthOfUpperTriangularMatrix", IsMatrixOrMatrixObj );


#############################################################################
Expand Down Expand Up @@ -402,7 +402,7 @@ DeclareSynonym( "DeterminantMatDivFree", DeterminantMatrixDivFree );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "DimensionsMat", IsMatrix );
DeclareAttribute( "DimensionsMat", IsMatrixOrMatrixObj );


#############################################################################
Expand Down Expand Up @@ -449,7 +449,7 @@ DeclareAttribute( "DimensionsMat", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "ElementaryDivisorsMat", [IsRing,IsMatrix] );
DeclareOperation( "ElementaryDivisorsMat", [IsRing, IsMatrixOrMatrixObj] );
DeclareGlobalFunction( "ElementaryDivisorsMatDestructive" );

#############################################################################
Expand Down Expand Up @@ -522,7 +522,7 @@ DeclareGlobalFunction( "ElementaryDivisorsMatDestructive" );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "ElementaryDivisorsTransformationsMat", [IsRing,IsMatrix] );
DeclareOperation( "ElementaryDivisorsTransformationsMat", [IsRing, IsMatrixOrMatrixObj] );
DeclareGlobalFunction( "ElementaryDivisorsTransformationsMatDestructive" );

#############################################################################
Expand All @@ -539,7 +539,7 @@ DeclareGlobalFunction( "ElementaryDivisorsTransformationsMatDestructive" );
## </Description>
## </ManSection>
##
DeclareOperation( "TriangulizedNullspaceMatNT", [ IsMatrix ] );
DeclareOperation( "TriangulizedNullspaceMatNT", [ IsMatrixOrMatrixObj ] );


#############################################################################
Expand All @@ -565,8 +565,8 @@ DeclareOperation( "TriangulizedNullspaceMatNT", [ IsMatrix ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "NullspaceMat", IsMatrix );
DeclareAttribute( "TriangulizedNullspaceMat", IsMatrix );
DeclareAttribute( "NullspaceMat", IsMatrixOrMatrixObj );
DeclareAttribute( "TriangulizedNullspaceMat", IsMatrixOrMatrixObj );


#############################################################################
Expand Down Expand Up @@ -605,8 +605,8 @@ DeclareAttribute( "TriangulizedNullspaceMat", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "NullspaceMatDestructive", [ IsMatrix and IsMutable] );
DeclareOperation( "TriangulizedNullspaceMatDestructive", [ IsMatrix and IsMutable] );
DeclareOperation( "NullspaceMatDestructive", [ IsMatrixOrMatrixObj and IsMutable] );
DeclareOperation( "TriangulizedNullspaceMatDestructive", [ IsMatrixOrMatrixObj and IsMutable] );


#############################################################################
Expand Down Expand Up @@ -678,7 +678,7 @@ DeclareOperation( "Eigenvalues", [ IsRing, IsMatrixOrMatrixObj ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "Eigenspaces", [ IsRing, IsMatrix ] );
DeclareOperation( "Eigenspaces", [ IsRing, IsMatrixOrMatrixObj ] );

#############################################################################
##
Expand All @@ -694,7 +694,7 @@ DeclareOperation( "Eigenspaces", [ IsRing, IsMatrix ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "Eigenvectors", [ IsRing, IsMatrix ] );
DeclareOperation( "Eigenvectors", [ IsRing, IsMatrixOrMatrixObj ] );


#############################################################################
Expand All @@ -717,7 +717,7 @@ DeclareOperation( "Eigenvectors", [ IsRing, IsMatrix ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "ProjectiveOrder", IsMatrix );
DeclareAttribute( "ProjectiveOrder", IsMatrixOrMatrixObj );

#############################################################################
##
Expand Down Expand Up @@ -825,7 +825,7 @@ DeclareSynonymAttr( "RankMatDestructive", RankMatrixDestructive );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "SemiEchelonMat", IsMatrix );
DeclareAttribute( "SemiEchelonMat", IsMatrixOrMatrixObj );

#############################################################################
##
Expand All @@ -849,7 +849,7 @@ DeclareAttribute( "SemiEchelonMat", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "SemiEchelonMatDestructive", [ IsMatrix and IsMutable] );
DeclareOperation( "SemiEchelonMatDestructive", [ IsMatrixOrMatrixObj and IsMutable] );


#############################################################################
Expand Down Expand Up @@ -886,7 +886,7 @@ DeclareOperation( "SemiEchelonMatDestructive", [ IsMatrix and IsMutable] );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "SemiEchelonMatTransformation", IsMatrix );
DeclareAttribute( "SemiEchelonMatTransformation", IsMatrixOrMatrixObj );

#############################################################################
##
Expand All @@ -902,7 +902,7 @@ DeclareAttribute( "SemiEchelonMatTransformation", IsMatrix );
## </ManSection>
##
DeclareOperation( "SemiEchelonMatTransformationDestructive", [
IsMatrix and IsMutable ] );
IsMatrixOrMatrixObj and IsMutable ] );


#############################################################################
Expand Down Expand Up @@ -1034,7 +1034,7 @@ DeclareSynonym( "MutableTransposedMat", TransposedMatMutable ); # needed?
## </Description>
## </ManSection>
##
DeclareOperation( "MutableTransposedMatDestructive", [IsMatrix and IsMutable] );
DeclareOperation( "MutableTransposedMatDestructive", [IsMatrixOrMatrixObj and IsMutable] );


#############################################################################
Expand Down Expand Up @@ -1062,7 +1062,7 @@ DeclareOperation( "MutableTransposedMatDestructive", [IsMatrix and IsMutable] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "TransposedMatDestructive", [ IsMatrix ] );
DeclareOperation( "TransposedMatDestructive", [ IsMatrixOrMatrixObj ] );



Expand All @@ -1085,7 +1085,7 @@ DeclareOperation( "TransposedMatDestructive", [ IsMatrix ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareProperty( "IsMonomialMatrix", IsMatrix );
DeclareProperty( "IsMonomialMatrix", IsMatrixOrMatrixObj );


#############################################################################
Expand All @@ -1110,7 +1110,7 @@ DeclareProperty( "IsMonomialMatrix", IsMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "InverseMatMod", [ IsMatrix, IsObject ] );
DeclareOperation( "InverseMatMod", [ IsMatrixOrMatrixObj, IsObject ] );


#############################################################################
Expand Down Expand Up @@ -1145,11 +1145,11 @@ DeclareOperation( "KroneckerProduct", [ IsMatrixOrMatrixObj, IsMatrixOrMatrixObj
## <Oper Name="SolutionMatNoCo" Arg='mat, vec'/>
##
## <Description>
## Does thework for <C>SolutionMat</C> and <C>SolutionMatDestructive</C>.
## Does the work for <C>SolutionMat</C> and <C>SolutionMatDestructive</C>.
## </Description>
## </ManSection>
##
DeclareOperation( "SolutionMatNoCo", [ IsMatrix, IsRowVector ] );
DeclareOperation( "SolutionMatNoCo", [ IsMatrixOrMatrixObj, IsRowVector ] );


#############################################################################
Expand All @@ -1167,7 +1167,7 @@ DeclareOperation( "SolutionMatNoCo", [ IsMatrix, IsRowVector ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "SolutionMat", [ IsMatrix, IsRowVector ] );
DeclareOperation( "SolutionMat", [ IsMatrixOrMatrixObj, IsRowVector ] );

#############################################################################
##
Expand Down Expand Up @@ -1199,7 +1199,7 @@ DeclareOperation( "SolutionMat", [ IsMatrix, IsRowVector ] );
## <#/GAPDoc>
##
DeclareOperation( "SolutionMatDestructive",
[ IsMatrix and IsMutable, IsRowVector ] );
[ IsMatrixOrMatrixObj and IsMutable, IsRowVector ] );


############################################################################
Expand All @@ -1225,7 +1225,7 @@ DeclareOperation( "SolutionMatDestructive",
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "SumIntersectionMat", [ IsMatrix, IsMatrix ] );
DeclareOperation( "SumIntersectionMat", [ IsMatrixOrMatrixObj, IsMatrixOrMatrixObj ] );



Expand All @@ -1248,7 +1248,7 @@ DeclareOperation( "SumIntersectionMat", [ IsMatrix, IsMatrix ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "TriangulizedMat", [ IsMatrix ] );
DeclareOperation( "TriangulizedMat", [ IsMatrixOrMatrixObj ] );
DeclareSynonym( "RREF", TriangulizedMat);

#############################################################################
Expand Down Expand Up @@ -1279,7 +1279,7 @@ DeclareSynonym( "RREF", TriangulizedMat);
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "TriangulizeMat", [ IsMatrix and IsMutable ] );
DeclareOperation( "TriangulizeMat", [ IsMatrixOrMatrixObj and IsMutable ] );


#############################################################################
Expand Down Expand Up @@ -1473,7 +1473,7 @@ DeclareGlobalFunction( "BlownUpVector" );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "DiagonalizeMat", [IsRing,IsMatrix and IsMutable] );
DeclareOperation( "DiagonalizeMat", [IsRing, IsMatrixOrMatrixObj and IsMutable] );


#############################################################################
Expand Down Expand Up @@ -1927,7 +1927,7 @@ DeclareSynonymAttr( "TraceMat", TraceMatrix );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "JordanDecomposition", IsMatrix );
DeclareAttribute( "JordanDecomposition", IsMatrixOrMatrixObj );


#############################################################################
Expand Down Expand Up @@ -2087,12 +2087,12 @@ DeclareSynonym("OnSubspacesByCanonicalBasisGF2",OnSubspacesByCanonicalBasis);
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "CharacteristicPolynomial", IsMatrix );
DeclareOperation( "CharacteristicPolynomial", [ IsMatrix, IsPosInt ] );
DeclareAttribute( "CharacteristicPolynomial", IsMatrixOrMatrixObj );
DeclareOperation( "CharacteristicPolynomial", [ IsMatrixOrMatrixObj, IsPosInt ] );
DeclareOperation( "CharacteristicPolynomial",
[ IsRing, IsRing, IsMatrix, IsPosInt ] );
[ IsRing, IsRing, IsMatrixOrMatrixObj, IsPosInt ] );
DeclareOperation( "CharacteristicPolynomial",
[ IsRing, IsRing, IsMatrix ] );
[ IsRing, IsRing, IsMatrixOrMatrixObj ] );


#############################################################################
Expand All @@ -2110,7 +2110,7 @@ DeclareOperation( "CharacteristicPolynomial",
##
DeclareOperation("CharacteristicPolynomialMatrixNC",
#IsField is not yet known
[IsRing,IsOrdinaryMatrix,IsPosInt]);
[IsRing,IsMatrixOrMatrixObj,IsPosInt]);


#############################################################################
Expand All @@ -2128,7 +2128,7 @@ DeclareOperation("CharacteristicPolynomialMatrixNC",
##
DeclareOperation("MinimalPolynomialMatrixNC",
#IsField is not yet known
[IsRing,IsOrdinaryMatrix,IsPosInt]);
[IsRing,IsMatrixOrMatrixObj,IsPosInt]);

#############################################################################
##
Expand Down
Loading
Loading