Make PrimitiveGroupsAvailable return false if artifact not downloaded#61
Conversation
|
Thanks! Unfortunately CI fails, so this won't make it into GAP 4.15.0-beta2, but it can still get into the final version. |
|
This now also prints some info message to inform a user about the zenodo artifact (as suggested by @wilfwilson in #59 (comment)). If I understand the Oscar src code, this info message should be suppressed by https://github.com/oscar-system/Oscar.jl/blob/b16b90b411541c16408c9b3ebd07ebf63b9476e1/src/Oscar.jl#L124, which is intended IMO until oscar-system/Oscar.jl#5293 is implemented. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 99.91% 99.91% -0.01%
==========================================
Files 46 46
Lines 383082 383098 +16
==========================================
+ Hits 382761 382763 +2
- Misses 321 335 +14
🚀 New features to boost your workflow:
|
| if PrimGrpArtifactFilename(deg,1) <> fail then | ||
| return true; | ||
| else | ||
| Info(InfoWarning,1,"Note that primitive groups of degree 4096 to 8191 must be downloaded separately. They can be obtained from https://doi.org/10.5281/zenodo.10411366"); |
There was a problem hiding this comment.
This could be really irritating in code that calls this function a lot. Perhaps it should only be shown once?
Anyway, we could also just wait and see if someone complains and then do it then.
This is an attempt to resolve #59.
The check is not optimal as we don't know the
nrinPrimitiveGroupsAvailable, but I think it is already good to assume that someone that downloaded at least the first file of the artifact also downloaded the rest of it.cc @fingolfin